Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add transfer usdc roles to make migration two-step #88

Merged
merged 4 commits into from
Jul 1, 2024
Merged

chore: add transfer usdc roles to make migration two-step #88

merged 4 commits into from
Jul 1, 2024

Conversation

excaliborr
Copy link
Contributor

🤖 Linear

Closes OPT-XXX

hexshire
hexshire reviewed Jul 1, 2024
View reviewed changes
Copy link
Member

@hexshire hexshire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that after receiveStopMessaging is called callUsdcTransaction should be disabled somehow since is a good idea to avoid that the adapter owner could upgrade or add a minter or something before transferUSDCRoles is executed.

Since callUsdcTransaction is an ownable function, maybe renounce the adapter ownership on receiveStopMessaging

hexshire
hexshire previously approved these changes Jul 1, 2024
View reviewed changes
@excaliborr excaliborr merged commit 7b607d0 into dev Jul 1, 2024
4 checks passed
@excaliborr excaliborr deleted the chore/transfer-usdc-roles branch July 1, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xDiscotech 0xDiscotech 0xDiscotech approved these changes

@hexshire hexshire hexshire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@excaliborr @0xDiscotech @hexshire