Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: linked adapter set in constructor #9

Merged
merged 2 commits into from
May 9, 2024
Merged

refactor: linked adapter set in constructor #9

merged 2 commits into from
May 9, 2024

Conversation

excaliborr
Copy link
Contributor

@excaliborr excaliborr commented May 8, 2024 •
edited
Loading

🤖 Linear

Closes OPT-38

@linear Linear
Copy link

linear bot commented May 8, 2024

OPT-38 linkedAdapter set in constructor of BridgeAdapter

setLinkedAdapter can be removed and linkedAdapter will be set in the constructor

@excaliborr excaliborr marked this pull request as ready for review May 8, 2024 19:31
hexshire
hexshire approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@hexshire hexshire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@excaliborr excaliborr merged commit 890ea58 into dev May 9, 2024
4 checks passed
@excaliborr excaliborr deleted the refactor/adapter-layout branch May 9, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hexshire hexshire hexshire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@excaliborr @hexshire