fix: potential second minter blocks burnLockedUSDC #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xDiscotech
reviewed
Jul 3, 2024
src/contracts/L2OpUSDCFactory.sol
Outdated
Comment on lines
40
to
49
| bytes memory _cachedBytes = abi.encode(_usdcImplementation); | ||
| _cachedBytes = bytes.concat(USDC_PROXY_CREATION_CODE, _cachedBytes); | ||
| (address _usdcProxy) = _deployCreate(_cachedBytes); | ||
| emit USDCProxyDeployed(_usdcProxy); | ||
|
|
||
| // Deploy L2 Adapter | ||
| address _l2Messenger = 0x4200000000000000000000000000000000000007; | ||
| bytes memory _l2AdapterCArgs = abi.encode(_usdcProxy, _l2Messenger, _l1Adapter, _l2AdapterOwner); | ||
| bytes memory _l2AdapterInitCode = bytes.concat(type(L2OpUSDCBridgeAdapter).creationCode, _l2AdapterCArgs); | ||
| (address _l2Adapter) = _deployCreate(_l2AdapterInitCode); | ||
| _cachedBytes = abi.encode(_usdcProxy, _l2Messenger, _l1Adapter, _l2AdapterOwner); | ||
| _cachedBytes = bytes.concat(type(L2OpUSDCBridgeAdapter).creationCode, _cachedBytes); | ||
| (address _l2Adapter) = _deployCreate(_cachedBytes); |
There was a problem hiding this comment.
Why these changes? Don't you feel the readability gets a bit worse?
There was a problem hiding this comment.
ah this was not supposed to get pushed, I was testing something
0xDiscotech
reviewed
Jul 3, 2024
| adapter.forTest_setBurnCaller(_circle); | ||
| adapter.forTest_setMessengerStatus(IL1OpUSDCBridgeAdapter.Status.Deprecated); | ||
|
|
||
| vm.mockCall(_usdc, abi.encodeWithSignature('burn(address,uint256)', address(adapter), _balanceOf), abi.encode(true)); |
There was a problem hiding this comment.
waring, could you add a solhint ignore?
hexshire
reviewed
Jul 3, 2024
| adapter.forTest_setBurnCaller(_circle); | ||
| adapter.forTest_setMessengerStatus(IL1OpUSDCBridgeAdapter.Status.Deprecated); | ||
|
|
||
| vm.mockCall(_usdc, abi.encodeWithSignature('burn(address,uint256)', address(adapter), _balanceOf), abi.encode(true)); |
hexshire
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes OPT-XXX