feat: rename mint/burn and add SuperchainERC20 #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: rename optimism superchain erc20 to superchain erc20
* chore: update natspec and errors
* refactor: move storage and erc20 metadata functions to implementation * chore: update interfaces
0xDiscotech
reviewed
Oct 1, 2024
Comment on lines
8
to
9
| /// @title ISuperchainERC20Errors | ||
| /// @notice Interface containing the errors added in the SuperchainERC20 implementation. |
There was a problem hiding this comment.
Suggested change
| /// @title ISuperchainERC20Errors | |
| /// @notice Interface containing the errors added in the SuperchainERC20 implementation. | |
| /// @title IOptimismSuperchainERC20Errors | |
| /// @notice Interface containing the errors added in the OptimismSuperchainERC20 implementation. |
Comment on lines
15
to
16
| /// @title ISuperchainERC20Extension | ||
| /// @notice This interface is available on the SuperchainERC20 contract. |
There was a problem hiding this comment.
Suggested change
| /// @title ISuperchainERC20Extension | |
| /// @notice This interface is available on the SuperchainERC20 contract. | |
| /// @title IOptimismSuperchainERC20Extension | |
| /// @notice This interface is available on the OptimismSuperchainERC20 contract. |
Comment on lines
42
to
43
| /// @title ISuperchainERC20 | ||
| /// @notice Combines Solady's ERC20 interface with the SuperchainERC20Extension interface. |
There was a problem hiding this comment.
Suggested change
| /// @title ISuperchainERC20 | |
| /// @notice Combines Solady's ERC20 interface with the SuperchainERC20Extension interface. | |
| /// @title IOptimismSuperchainERC20 | |
| /// @notice Combines Solady's ERC20 interface with the IOptimismSuperchainERC20Extension interface. |
0xDiscotech
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes OPT-258