Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: mirgation nextJS #5

Merged
merged 27 commits into from
Mar 19, 2024
Merged

chore: mirgation nextJS #5

merged 27 commits into from
Mar 19, 2024

Conversation

0xtiti
Copy link
Contributor

@0xtiti 0xtiti commented Mar 17, 2024

NextJS migration

NextJS migration with vitest changes (router)

Checklist before requesting a review

  • I have conducted a self-review of my code.
  • If it is a core feature, I have included comprehensive tests.
  • Do we need to implement analytics?
  • Will this be part of a product update? If yes, please write one sentence about this update.

0xArdy
0xArdy requested changes Mar 18, 2024
View reviewed changes
Copy link
Member

@0xArdy 0xArdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
next.config.mjs Outdated Show resolved Hide resolved
src/containers/Footer/index.tsx Outdated Show resolved Hide resolved
src/containers/Header/index.tsx Outdated Show resolved Hide resolved
src/containers/Layout/index.tsx Outdated Show resolved Hide resolved
vitest.config.ts Outdated Show resolved Hide resolved
.eslintrc.cjs Outdated Show resolved Hide resolved
src/pages/_app.tsx Outdated Show resolved Hide resolved
0xArdy
0xArdy requested changes Mar 19, 2024
View reviewed changes
Copy link
Member

@0xArdy 0xArdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one smol comment

package.json Outdated Show resolved Hide resolved
@0xArdy 0xArdy merged commit bccf81a into dev Mar 19, 2024
4 checks passed
@0xArdy 0xArdy deleted the chore/migration-nextjs branch March 19, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xArdy 0xArdy 0xArdy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xtiti @0xArdy