Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config fix for Model #15

Merged
merged 2 commits into from
Jun 10, 2020
Merged

Config fix for Model #15

merged 2 commits into from
Jun 10, 2020

Conversation

mazhurin
Copy link
Collaborator

Rollback of the config change in model_path PR. Now, as before, engine.training.model refers to the full module path of the Model class(not the Enum key).

@mazhurin
Rollback of the config change in model_path PR. Now, as before, engin…
8d17664 
…e.training.model refers to the full module path of the Model class(not the Enum key).
@mazhurin mazhurin requested a review from mkaranasou June 10, 2020 13:03
mkaranasou
mkaranasou approved these changes Jun 10, 2020
View reviewed changes
Copy link
Collaborator

@mkaranasou mkaranasou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks LGTM 👍

@mazhurin mazhurin merged commit be2e481 into develop Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkaranasou mkaranasou mkaranasou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mazhurin @mkaranasou