Deal with aliased columns in the group by section #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I forgot to run black, before the pull request, the problem is a missing return to line, should I open another pull request ? |
|
Hi there, you should be able to make a commit straight to your |
|
@rishsriv checks are successful, would be great if you can accept the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@wongjingping I had a hard time with git trying to squash commits... I still suck at git HHHHH so I just forked the library again and applied the changes I talked about earlier. The test pass just fine 👍
PS 1 : I could not quite understand your suggestions as it will only work when column_str contains only one column, I will be happy to apply it if you can explain it more.
PS 2 : maybe a test with "AS" can be added to
test_get_all_minimal_queriesto ensure future changes still takes the issue into consideration.