Maros WITH-WINDOW now accepts keywords as flags. #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge Raylib 4.5, Raygui 3.5, other enhancements
shelvick
requested changes
Aug 12, 2023
There was a problem hiding this comment.
As it stands this is an API-breaking change, which is unnecessary, IMO. Change it so you can use keywords or the +flag-* constants, and I'll merge.
Also, please export +keyword-flag+ or offer some other way to quickly know what the flag options are. I know they're more verbose but personally I like the ability to type +flag- and let autocomplete give me the list.
Sorry, but I don't know where to put the FLAG->CODE and FLAGS ->CODES functions.
I could see all of your additions going into a new window.lisp file but it's fine for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I didn't like the way the flags were passed to the WITH-WINDOW macro. I decided to tweak it a bit. Now it accepts keywords. Do you think this is a good idea? Do you think it's worth continuing to translate functions that work with flags into keywords?
Sorry, but I don't know where to put the FLAG->CODE and FLAGS ->CODES functions.
Thanks.