don't pad 4 digit tracts and change column names to start with census… #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should this be 0.5.2 or 0.6.0? It's technically a bug fix but I wasn't sure since it will change the output. |
cole-brokamp
requested changes
Jul 13, 2022
There was a problem hiding this comment.
0.6.0 sounds good to me. See my comment about the README and clarification around identifiers.
Let's also combine the info in "Geomarker Methods" into the "Geomarker Data" subsection in the README. I think "geomarker methods" for this one should only be about how we use 5072 projection to do a spatial overlay. All of how we created and improved the census tract geography files can go into "geomarker data".
cole-brokamp
requested review from
cole-brokamp
and removed request for
cole-brokamp
cole-brokamp
approved these changes
Jul 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… instead of fips