Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: implement dynamic app version #122

Merged
merged 3 commits into from
Feb 9, 2024
Merged

fix: implement dynamic app version #122

merged 3 commits into from
Feb 9, 2024

Conversation

deggja
Copy link
Owner

@deggja deggja commented Feb 9, 2024

remove constant version from root.go, rely on ldflags in go to set application version when building the app

e.g. go build -ldflags "-X 'github.com/deggja/netfetch/backend/cmd.Version=3.2.7'" -o netfetch

this fixes #115

Signed-off-by: deggja <danieldagfinrud@gmail.com>
Signed-off-by: deggja <danieldagfinrud@gmail.com>
Signed-off-by: deggja <danieldagfinrud@gmail.com>
@deggja deggja merged commit 136509b into main Feb 9, 2024
@deggja deggja deleted the fix/bug_115 branch February 9, 2024 21:45
deggja added a commit that referenced this pull request May 31, 2024
fix: implement dynamic app version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version is a constant so the same version is reported no matter the actual version.
1 participant