We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Destroying an app via Deis cli does not clean up the build slugs when app name fails to match regex.
Builder Version: 2.7.1 Storage Driver: Swift Steps to reproduce: deis destroy --app=my-app kubectl logs BUILDER --namespace=deis
deis destroy --app=my-app
kubectl logs BUILDER --namespace=deis
Only log line written is clearing the cache: Cleaner deleting cache home/my-app/cache for app my-app
Cleaner deleting cache home/my-app/cache for app my-app
Missing the lines in code at #445
log.Info("Cleaner deleting slug %s for app %s", obj, app)
my-app had over 100 builds.
my-app
Issue is potentially the regex matching:
gitRegex, err := regexp.Compile(^/ + fmt.Sprintf(gitreceive.GitKeyPattern, app, ".{8}") + "$")
gitRegex, err := regexp.Compile(
+ fmt.Sprintf(gitreceive.GitKeyPattern, app, ".{8}") + "$")
The text was updated successfully, but these errors were encountered:
@markkwasnick can you describe the slug tarball names in your object store? they should look something like /home/jangly-tailbone:git-11241b3a.
/home/jangly-tailbone:git-11241b3a
Sorry, something went wrong.
Here are a couple
fileshome/synergy-sf:git-9aed6276/push/slug.tgz
fileshome/synergy-sf:git-9dc6342c/push/slug.tgz
This issue was moved to teamhephy/builder#16
No branches or pull requests
Destroying an app via Deis cli does not clean up the build slugs when app name fails to match regex.
Builder Version: 2.7.1
Storage Driver: Swift
Steps to reproduce:
deis destroy --app=my-app
kubectl logs BUILDER --namespace=deis
Only log line written is clearing the cache:
Cleaner deleting cache home/my-app/cache for app my-app
Missing the lines in code at #445
log.Info("Cleaner deleting slug %s for app %s", obj, app)
my-app
had over 100 builds.Issue is potentially the regex matching:
gitRegex, err := regexp.Compile(
^/+ fmt.Sprintf(gitreceive.GitKeyPattern, app, ".{8}") + "$")
The text was updated successfully, but these errors were encountered: