Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builder fails to cleanup object store slugs #16

Open
Cryptophobia opened this issue Mar 21, 2018 · 2 comments
Open

Builder fails to cleanup object store slugs #16

Cryptophobia opened this issue Mar 21, 2018 · 2 comments

Comments

@Cryptophobia
Copy link
Member

From @markkwasnick on March 10, 2017 16:38

Destroying an app via Deis cli does not clean up the build slugs when app name fails to match regex.

Builder Version: 2.7.1
Storage Driver: Swift
Steps to reproduce:
deis destroy --app=my-app
kubectl logs BUILDER --namespace=deis

Only log line written is clearing the cache:
Cleaner deleting cache home/my-app/cache for app my-app

Missing the lines in code at #445

log.Info("Cleaner deleting slug %s for app %s", obj, app)

my-app had over 100 builds.

Issue is potentially the regex matching:

gitRegex, err := regexp.Compile(^/ + fmt.Sprintf(gitreceive.GitKeyPattern, app, ".{8}") + "$")

Copied from original issue: deis/builder#494

@Cryptophobia
Copy link
Member Author

From @bacongobbler on March 10, 2017 16:40

@markkwasnick can you describe the slug tarball names in your object store? they should look something like /home/jangly-tailbone:git-11241b3a.

@Cryptophobia
Copy link
Member Author

From @markkwasnick on March 10, 2017 17:0

Here are a couple

fileshome/synergy-sf:git-9aed6276/push/slug.tgz

fileshome/synergy-sf:git-9dc6342c/push/slug.tgz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant