Skip to content
This repository was archived by the owner on Jun 3, 2024. It is now read-only.

fix(rootfs/Dockerfile): update golangci-lint installation script #349

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

seleznev
Copy link
Contributor

@seleznev seleznev commented Sep 6, 2023

Hi!

install.goreleaser.com was deprecated a long time ago and now it's completely removed:

$ curl install.goreleaser.com
curl: (6) Could not resolve host: install.goreleaser.com

As a result, the latest image doesn't contain golangci-lint anymore:

$ docker run -it --rm quay.io/deis/go-dev:latest golangci-lint --version
docker: Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: exec: "golangci-lint": executable file not found in $PATH: unknown.

For example, one of old images:

$ docker run -it --rm quay.io/deis/go-dev:v1.34.4 golangci-lint --version
golangci-lint has version 1.44.0 built from 617470fa on 2022-01-25T11:31:17Z

So, I suggest to update Dockerfile according to golangci-lint docs.

Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you @seleznev!

@mboersma mboersma merged commit 326bf6b into deis:main Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants