Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(log): fix panic error when building app log message #139

Merged
merged 1 commit into from
Mar 23, 2017

Conversation

bacongobbler
Copy link
Member

closes #136 by catching when the pod name fails the pod regex.

@bacongobbler bacongobbler added this to the v2.13 milestone Mar 22, 2017
@bacongobbler bacongobbler self-assigned this Mar 22, 2017
@deis-bot
Copy link

@jchauncey and @krancour are potential reviewers of this pull request based on my analysis of git blame information. Thanks @bacongobbler!

@codecov-io
Copy link

codecov-io commented Mar 22, 2017

Codecov Report

Merging #139 into master will increase coverage by 0.63%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #139      +/-   ##
=========================================
+ Coverage   49.87%   50.5%   +0.63%     
=========================================
  Files          13      13              
  Lines         391     396       +5     
=========================================
+ Hits          195     200       +5     
  Misses        172     172              
  Partials       24      24
Impacted Files Coverage Δ
log/message_handler.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec3c26c...2569391. Read the comment docs.

@mboersma mboersma added the LGTM1 label Mar 22, 2017
@bacongobbler bacongobbler merged commit ac50ac9 into deis:master Mar 23, 2017
@bacongobbler bacongobbler deleted the 136-fix-panic branch March 23, 2017 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic: runtime error: index out of range
5 participants