Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the service catalog lookup construction process #85

Closed
arschles opened this issue Aug 17, 2016 · 2 comments
Closed

Optimize the service catalog lookup construction process #85

arschles opened this issue Aug 17, 2016 · 2 comments
Milestone

Comments

@arschles
Copy link
Member

arschles commented Aug 17, 2016

In #72, the service catalog is constructed by:

  1. Fetching all available services from the backend CF service broker
  2. Trying to publish all those services to the k8s ServiceCatalogEntry third party resource (ignoring errors that the entry already exists)
  3. Fetching the catalog from the k8s ServiceCatalogEntry third party resource

Steps (2) and (3) can be merged as an optimization. Already-existing entries and newly published ones should be written to the lookup table at the same time, and we'll only have to write ServiceCatalogEntrys once.

@arschles
Copy link
Member Author

#87 will be useful in unit testing this change

@arschles
Copy link
Member Author

We've split steward into steward-framework, the Go SDK for Kubernetes resources and control loops, and steward-cf, the CF broker API implementation on top of steward-framework.

steward-framework constructs the service catalog differently (according to ServiceClass described in kubernetes-retired/service-catalog#31), so this issue no longer applies; closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant