Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cmd): add auth:whoami --all #145

Merged
merged 1 commit into from
Jul 25, 2016
Merged

Conversation

bacongobbler
Copy link
Member

@bacongobbler bacongobbler commented Jul 21, 2016

closes #54
supercedes #118

@deis-bot
Copy link

@Joshua-Anderson and @arschles are potential reviewers of this pull request based on my analysis of git blame information. Thanks @bacongobbler!

@bacongobbler
Copy link
Member Author

Ah, I think the reason why it's failing to build is because my PR was out of date with master and had an older Jenkinsfile. That should do it!

@bacongobbler
Copy link
Member Author

Hmm, nope that didn't do the trick. @vdice am I missing something here to make the PR build with deis/controller-sdk-go#36?

@vdice
Copy link
Member

vdice commented Jul 22, 2016

@bacongobbler We don't yet have the mechanism in place for 'Requires' between workflow-cli and controller-sdk-go. As of this writing, a PR in controller-sdk-go is run thru e2e by using that version in an otherwise 'master' version of workflow-cli, and, likewise, a PR in workflow-cli just defaults to using the 'master' version of controller-sdk-go.

That being said, we should be in a good position to add the 'Requires' functionality for any PRs in the former case (controller-sdk-go). We should be able to clone into a forked workflow-cli repo at a certain commit before building the binary with the controller-sdk-go commit. I will create this ticket. (Edit: deis/controller-sdk-go#51)

@bacongobbler
Copy link
Member Author

Adding both LGTM labels as SDK, controller and e2e auth:whoami PRs have been approved for merge, so I'm assuming this is fine as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement auth:whoami
3 participants