Feature/Redis Trigger #117
Conversation
Signed-off-by: Suneet Nangia <suneetnangia@gmail.com>
Signed-off-by: Suneet Nangia <suneetnangia@gmail.com>
Signed-off-by: Suneet Nangia <suneetnangia@gmail.com>
There was a problem hiding this comment.
LGTM! Made a few comments.
FYI, I am working on upgrading the spin shim to use youki container runtime, and in the process of doing that, I am thinking about using generic trigger from Spin so that it not only supports http and redis, but any spin custom triggers. But I do think this PR is mergable.
| info!(" >>> running spin trigger"); | ||
| f = redis_trigger.run(spin_trigger::cli::NoArgs); | ||
| } | ||
| _ => todo!("Only Http and Redis triggers are currently supported."), |
There was a problem hiding this comment.
I am working on a generic trigger implementaion for the spin shim. This definitely helps!
Signed-off-by: Suneet Nangia <suneetnangia@gmail.com>
|
All done @Mossaka. Thanks |
There was a problem hiding this comment.
lgtm!
Would you like to add the spin-inbound-redis image to the release pipeline? @suneetnangia
|
I am going to merge this in and we can have follow ups resolved in future PRs. |
Can do, but was wondering if I should add integration tests for redis based images (both inbound and outbound (existing)) prior to release, to ensure images always work when we make changes? |
|
@suneetnangia it's always a good idea to add more integration tests, specifically for redis based images. |
This commit adds an integration test for spin-keyvalue using dynamic config file that was introduced by deislabs#179 and an integraion test for outbound redis introduced by deislabs#117 Signed-off-by: jiaxiao zhou <jiazho@microsoft.com>
This commit adds an integration test for spin-keyvalue using dynamic config file that was introduced by deislabs#179 and an integraion test for outbound redis introduced by deislabs#117 Signed-off-by: jiaxiao zhou <jiazho@microsoft.com>
Added Redis trigger support in addition to existing http in the shim.
I'll add integration test support for this and also the existing "spin-outbound-redis" in next PR.
We are currently using a private version of this shim in our repo to demo wasm/containers messaging using Redis in K3d. https://github.com/suneetnangia/wasm-orchestration-with-spin
P.S. Let me know if you want to make any changes. Thanks