-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump spin version to 1.5.0 #151
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! But it looks like the CI failed
IIUC, there's a problem building a dependency introduced by the new LLM feature of spin. |
Is it becuase the spin image is still using spin SDK Nvm, I realized that it is the shim build that failed. |
Ok, I digged a bit into it. The main issue is that According to this issue xmrig/xmrig#2882, that intrinsic is not present in I am wondering what the right fix is, since |
Ok, the solution I found is less than idea, and it's polyfilling the missing functions in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
minor comment: add a readme on polyfill
folder to describe what this does and when shall we remove it.
This can be done in a future PR.
Need a rebase |
7145cfc
to
f636a57
Compare
Done. If there's an update to the compiler in cross-rs, the polyfill will become a no-op as it does a feature test before acting.
|
Could you please sign your commit @jprendes ? |
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
sorry, changed laptops and hadn't set up git correctly! |
Bump spin
1.4.1
->1.5.0
.