revert docker build-push-action back to v3 #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jiaxiao zhou <jiazho@microsoft.com>
|
The workflow still specifies a platform, is that just ignored by |
|
I think so. That's what we were using at |
|
Im going to merge this in and trigger another release |
This was referenced Sep 21, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits revert #146's change that updated "docker/build-push-action" from
v3tov4. This is because the new images being pushed to ghci don't have Linux/amd64 platforms anymore, which then can't be pulled by Kubernetes. Note that this isn't a long term solution.After this PR merges, I will do another release of
v0.9.1CC @0xE282B0 @jprendes