Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add StdioTriggerHook to spin TriggerExecutorBuilder #170

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Add StdioTriggerHook to spin TriggerExecutorBuilder #170

merged 1 commit into from
Oct 25, 2023

Conversation

0xE282B0
Copy link
Contributor

As @jprendes mentioned #168 (comment), here is the missing line 😅

jprendes
jprendes approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@jprendes jprendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I haven't tested if this fixed the linked issue, but the change looks good.

Mossaka
Mossaka approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@Mossaka Mossaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Mossaka Mossaka merged commit 1d8c9ea into deislabs:main Oct 25, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jprendes jprendes jprendes approved these changes

@Mossaka Mossaka Mossaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xE282B0 @jprendes @Mossaka