Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experimentation to improve shim performance #196

Closed
wants to merge 2 commits into from
Closed

Experimentation to improve shim performance #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45990f0
Remove cranelift speed opt level
kate-goldenring Dec 22, 2023
dab473e
Update the ci workflow to work from a fork
kate-goldenring Dec 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,22 +18,22 @@ jobs:
arch: "aarch64"
}
shims:
- {
name: "slight",
version: "v1",
}
# - {
# name: "slight",
# version: "v1",
# }
- {
name: "spin",
version: "v2",
}
- {
name: "wws",
version: "v1",
}
- {
name: "lunatic",
version: "v1",
}
# - {
# name: "wws",
# version: "v1",
# }
# - {
# name: "lunatic",
# version: "v1",
# }
env:
ARCH: ${{ matrix.config.arch }}
steps:
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@ jobs:
- name: fmt
run: |
make fmt
build-wasm-images:
uses: ./.github/workflows/docker-build-push.yaml
with:
test: true
# build-wasm-images:
# uses: ./.github/workflows/docker-build-push.yaml
# with:
# test: true
build:
uses: ./.github/workflows/build.yaml
test:
Expand Down
6 changes: 1 addition & 5 deletions containerd-shim-spin/src/engine.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,11 +226,7 @@ impl SpinEngine {
runtime_config.merge_config_file(RUNTIME_CONFIG_PATH)?;
}
let mut builder = TriggerExecutorBuilder::new(loader);
builder
.hooks(StdioTriggerHook {})
.config_mut()
.wasmtime_config()
.cranelift_opt_level(spin_core::wasmtime::OptLevel::Speed);
builder.hooks(StdioTriggerHook {});
let init_data = Default::default();
let executor = builder.build(locked_url, runtime_config, init_data).await?;
Ok(executor)
Expand Down
Loading