Deprecate Ubuntu 18.04 #1468
Merged
Deprecate Ubuntu 18.04 #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyanDevs
force-pushed
the
cyan/deprecate-ubuntu-18.04
branch
3 times, most recently
from
def9aad to
c54c8c1
Compare
CyanDevs
commented
Apr 26, 2023
| self.assertRaises(OverflowError, posix.sched_setparam, 0, param) | ||
|
|
||
| @unittest.skipUnless(hasattr(posix, "sched_rr_get_interval"), "no function") | ||
| + @unittest.skip("Temporarily disabled in Mystikos") | ||
| def test_sched_rr_get_interval(self): | ||
| try: | ||
| interval = posix.sched_rr_get_interval(0) | ||
| @@ -1509,6 +1515,7 @@ def test_path_with_null_byte(self): |
There was a problem hiding this comment.
This test is disabled due to the following error
*** kernel panic: syscall.c(7828): _syscall(): unknown syscall: SYS_pidfd_open(): 434
There was a problem hiding this comment.
Its unlikely we'll support this syscall.
| libreadline-dev libsqlite3-dev libgdbm-dev libdb5.3-dev libbz2-dev \ | ||
| libexpat1-dev liblzma-dev libffi-dev git uuid-dev lsb-core wget | ||
|
|
||
| # Workaround broken crc32_z symbol on zlib 1.2.11 for Ubuntu 20.04 |
There was a problem hiding this comment.
crc32_z symbol is different between Ubuntu 20.04 and 18.04 even though both are v1.2.11. This is the error
ImportError: Error relocating /usr/lib/x86_64-linux-gnu/libz.so.1: crc32_z: symbol not found
There was a problem hiding this comment.
Hmm thats seems puzzling. The symbol type is different in the above output - FUNC(18.04) vs IFUNC(20.4). It might be our musl loader doesn't support IFUNC symbols.
cc: @anakrish
There was a problem hiding this comment.
This is the traceback:
test test_exceptions crashed -- Traceback (most recent call last):
File "/cpython/Lib/test/libregrtest/runtest.py", line 335, in _runtest_inner
refleak = _runtest_inner2(ns, test_name)
File "/cpython/Lib/test/libregrtest/runtest.py", line 280, in _runtest_inner2
the_module = importlib.import_module(abstest)
File "/cpython/Lib/importlib/__init__.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
File "<frozen importlib._bootstrap_external>", line 883, in exec_module
File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
File "/cpython/Lib/test/test_exceptions.py", line 13, in <module>
from test.support import (captured_stderr, check_impl_detail,
File "/cpython/Lib/test/support/script_helper.py", line 11, in <module>
import zipfile
File "/cpython/Lib/zipfile.py", line 6, in <module>
import binascii
ImportError: Error relocating /usr/lib/x86_64-linux-gnu/libz.so.1: crc32_z: symbol not found
test_exceptions failed (uncaught exception)
== Tests result: FAILURE ==
1 test failed:
test_exceptions
c54c8c1 to
c985e32
Compare
Signed-off-by: Chris Yan <chrisyan@microsoft.com>
Signed-off-by: Chris Yan <chrisyan@microsoft.com>
Signed-off-by: Chris Yan <chrisyan@microsoft.com>
Signed-off-by: Chris Yan <chrisyan@microsoft.com>
Signed-off-by: Chris Yan <chrisyan@microsoft.com>
CyanDevs
force-pushed
the
cyan/deprecate-ubuntu-18.04
branch
from
c985e32 to
7f1b5b8
Compare
vtikoo
reviewed
Apr 27, 2023
radhikaj
approved these changes
May 3, 2023
vtikoo
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deprecates Ubuntu 18.04 support and migrates anything still dependent on Ubuntu 18.04 to Ubuntu 20.04.