Configurable colcon path and install type, basic C/C++ problem matcher #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Felix Lelchuk <felix-el@users.noreply.github.com>
Signed-off-by: Felix Lelchuk <felix-el@users.noreply.github.com>
deitry
requested changes
Jul 26, 2021
There was a problem hiding this comment.
Thank you for such nice contribution!
I have just couple of minor comments addressing configuration descriptions.
On problem matcher - #16 implies support for all platforms and compilers. I picked up patterns for msbuild/C++ on Windows based on your problem matcher (I'll introduce them after merging your PR, see ddf0db4), but also it's necessary to have pattern matching for Python before closing that issue since Python is widely used as well.
Best regards,
Dmitriy
Signed-off-by: Felix Lelchuk <felix-el@users.noreply.github.com>
|
Makes sense, Dmitriy. I've just pushed these changes. |
|
Thank you! I'll push new version of extension quite soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Dmitriy,
I found this extension very useful and would like to contribute back few minor modifications which I personally required for my work.
My use case for 1. is:
I have a Bash script in my workspace that wraps colcon, giving me a chance to generate a
colcon.metaconfig file prior to building and to set extra--cmake-argsto createcompile_commands.json. Finally, I'm able to merge allcompile_commands.jsonfiles into one usingjqpost-build to get C/C++ completion working ("IntelliSense").All the best,
Felix