Merge pull request #136 from bweave/bweave/add-support-for-vscode

fix(VSCode): Turns out no addon required
dejan · Feb 22, 2018 · 2e1cbaa · 2e1cbaa
2 parents b26792f + 6faa4ba
commit 2e1cbaa
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/rails_panel/assets/javascripts/filters.js b/rails_panel/assets/javascripts/filters.js
@@ -16,7 +16,7 @@ angular.module('RailsPanel', [])
         emacs: "emacs://open?url=file://%s&line=%d&column=%d",
         atom: "atm://open?url=file://%s&line=%d&column=%d",
         mine: "x-mine://open?file=%s&line=%d",
-        vscode: "vscode://open?file=%s&line=%d"
+        vscode: "vscode://file%s:%d"
       }
       var editor = localStorage.getItem("railspanel.editor");
       var editorPrefix = mapping[editor]

diff --git a/rails_panel/options.html b/rails_panel/options.html
@@ -58,9 +58,6 @@ <h2>
         <label class="radio">
             <input type="radio" name="storage.editor" value="vscode" ng-model="editor">
             Visual Studio Code
-            <small>
-              (<a href="https://github.com/shengyou/vscode-handler" target="_blank">requires vscode-handler</a>)
-            </small>
         </label>
       </form>
       <div class="footer">Developed by <a href="http://rors.org" target="_blank">Dejan Simic</a></div>