Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dev caller location #146

Merged
merged 6 commits into from
Aug 1, 2019
Merged

Fix dev caller location #146

merged 6 commits into from
Aug 1, 2019

Conversation

gogiel
Copy link
Collaborator

@gogiel gogiel commented Oct 19, 2018 •
edited
Loading

Resolves #144
I was able to reproduce this by running app in /app which is a common Docker setup.
include? incorrectly matches meta_request/app_notifications.rb

@gogiel gogiel mentioned this pull request Oct 19, 2018
Closed
@gogiel
Copy link
Collaborator Author

gogiel commented Jul 2, 2019 •
edited
Loading

Hi @dejan. Can you find a moment to review it? Are there any other user are capable of merging requests? @modosc ?

I use RailsPanel every day and would love to contribute more by fixing outstanding issues.

Thanks!

@dejan
Copy link
Owner

dejan commented Jul 3, 2019 •
edited
Loading

Hi @gogiel, I've added you as a repo collaborator. Thanks for the help! I've also left some comments.

@gogiel gogiel requested a review from dejan July 4, 2019 21:36
@dejan dejan merged commit 968c6e2 into dejan:master Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dejan dejan dejan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Location column just seems to show MetaRequest itself
2 participants
@gogiel @dejan