Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support deployment strategy rolling update in DeploymentConfig #1222

Merged
merged 1 commit into from
Jun 23, 2023
Merged

feat: support deployment strategy rolling update in DeploymentConfig #1222

merged 1 commit into from
Jun 23, 2023

Conversation

Sgitario
Copy link
Collaborator

@Sgitario Sgitario requested a review from iocanel June 21, 2023 08:16
iocanel
iocanel requested changes Jun 21, 2023
View reviewed changes
Copy link
Member

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but added a minor request change about a conditional that is not very accurate.

...ift-annotations/src/main/java/io/dekorate/openshift/manifest/OpenshiftManifestGenerator.java Show resolved Hide resolved
@Sgitario Sgitario requested a review from iocanel June 21, 2023 12:05
iocanel
iocanel requested changes Jun 22, 2023
View reviewed changes
Copy link
Member

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still an iterm that needs to be addressed.

@Sgitario Sgitario requested a review from iocanel June 23, 2023 04:55
@sonarcloud
Copy link

sonarcloud bot commented Jun 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

iocanel
iocanel approved these changes Jun 23, 2023
View reviewed changes
Copy link
Member

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Sgitario Sgitario merged commit 277e890 into dekorateio:main Jun 23, 2023
@Sgitario Sgitario deleted the 34047 branch June 23, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iocanel iocanel iocanel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sgitario @iocanel