Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to Python 3.5 #58

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Port to Python 3.5 #58

wants to merge 20 commits into from

Conversation

tdsmith
Copy link

@tdsmith tdsmith commented Nov 25, 2016

This branch is compatible with both Python 2.7 and Python 3.5.

I adopt the convention that the Protocol class must accept and emit Unicode strings and is responsible for converting objects to bytes.

The changes to the tests are mostly small compatibility fixes with a few exceptions:

  • my redis is truncating floats in the sorting test differently than the test suite expects, so I'm skipping the test; I don't know if it's important to test the precision but this feels like something that Redis has changed
  • test_rename_same_src_dest succeeds on my redis install; it looks like renaming to the same name is allowed, now

I propose deleting the rename_same_src_dest test and adopting less stringent tests for the floating point sort test.

Thanks!

@tdsmith
Copy link
Author

tdsmith commented Nov 25, 2016

Incidentally: the awesome test suite made this much easier!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant