ExecutionContext rework. #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch. Don't know if it could be done in a non-breaking way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were missing process related typings at first. As I was adding them it turned out that getEventArgs and getEventSource return different types depending on the actual raised event. PowerApps documentation seems incomplete for many scenarios. I've mined next details through debugging:
I left any because there is some object with methods but they aren't documented anywhere.
Also getUrl isn't member of ExecutionContext. It is on the Page.
Generic ExecutionContext with additional type parameter for getEventArgs fits nice in type definitions. At the same time it brings breaking changes. Anyway I haven't found a way to make it backwards compatible.