Use Illuminate\Foundation\Testing\TestCase instead of Orchestra\Testbench\TestCase #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Orchestra\Testbench\TestCase Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
crynobone
commented
Feb 17, 2021
| use Illuminate\Queue\Queue; | ||
| use Illuminate\Support\ServiceProvider; | ||
| use Orchestra\Testbench\TestCase; | ||
| use Orchestra\Testbench\Concerns\CreatesApplication; |
There was a problem hiding this comment.
This should be testing Illuminate\Foundation\Testing\TestCase and not Orchestra\Testbench\TestCase.
I would recommend adding similar tests on orchestra/testbench-core to cover this issue.
There was a problem hiding this comment.
getPackageProviders won't work after this change, right? I'll adjust it to manually register it
There was a problem hiding this comment.
@deleugpn getPackageProviders exists in Orchestra\Testbench\Concerns\CreatesApplication.
There was a problem hiding this comment.
For simple tests such as this, we don't need Orchestra\Testbench\Concern\Testing where all the setUp, tearDown, and all other feature customs to Testbench exists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mior Muhammad Zaki crynobone@gmail.com