LOG-1772: Canoe: productionise Paddle #2
Conversation
README.md
Outdated
|
|
||
| ``` | ||
| $ go build | ||
| ``` |
There was a problem hiding this comment.
we should specify that Go must be installed only for development / tests. for actual usage, we'll be generating a binary which we can include instructions in the Readme for.
cli/data/get.go
Outdated
| path string | ||
| } | ||
|
|
||
| func (s *S3Target) copy() *S3Target { |
There was a problem hiding this comment.
is this here to ensure that we aren't mutating?
There was a problem hiding this comment.
I don't understand enough yet about Go to grasp if I should be just passing structs by value and allow the runtime to clone those from my understanding but yet.. here was just do that scenario where you want to be a good citzen:
class A
def initialize(options = {})
opts = options.dup
opts.merge(...)
end
end
There was a problem hiding this comment.
Yeah I wouldn't have this function, if anything we can just copy below; and copy is a built-in so it's not a great name. I would just pass by value, no reason to pass by reference here.
cli/data/get.go
Outdated
| source.path = readHEAD(session, source) | ||
| } | ||
|
|
||
| fmt.Println("Copying " + source.fullPath() + " to " + destination) |
There was a problem hiding this comment.
I kinda liked a more minimal output to be honest, no biggie though
| aws_secret_access_key=yyy | ||
| region=eu-west-1 | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Looks good!
We should probably add instructions to the README to create a new release (and create one once this is merge). The steps are:
- Set up github
export GITHUB_TOKEN=[YOUR_TOKEN] $ git tag -a v0.2.0 -m "[Comment]"$ git push origin v0.2.0$ goreleaser
(see https://goreleaser.com)
|
|
||
| ``` | ||
| > cat $HOME/.paddle.yaml | ||
| bucket: roo-bucket |
There was a problem hiding this comment.
Might be worth pointing out that these settings can be configured through ENV as well (e.g. BUCKET).
README.md
Outdated
| @@ -21,6 +21,8 @@ You will need create a `$HOME/.paddle.yaml` that contains the bucket name, e.g: | |||
| bucket: roo-bucket | |||
| ``` | |||
|
|
|||
| or if you prefer specific `BUCKET` as an environment variable | |||
Still work in progress, but just opening the PR to create some basic comments
===
Jira story #LOG-1772 in project Logistics: