Skip to content

Commit

Permalink
feat: Generated value file is last arg (#13)
Browse files Browse the repository at this point in the history
It simply places the --values=./values.yml argument at the very last place in
the whole command. This ensures that these values take precedence over other
value arguments.
  • Loading branch information
mpraski authored and colinjfw committed Oct 16, 2019
1 parent da02f60 commit 9e1a0cf
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -191,12 +191,12 @@ async function run() {
"--wait",
"--atomic",
`--namespace=${namespace}`,
"--values=./values.yml",
];
if (dryRun) args.push("--dry-run");
if (appName) args.push(`--set=app.name=${appName}`);
if (version) args.push(`--set=app.version=${version}`);
valueFiles.forEach(f => args.push(`--values=${f}`));
args.push("--values=./values.yml");

// Special behaviour is triggered if the track is labelled 'canary'. The
// service and ingress resources are disabled. Access to the canary
Expand Down

0 comments on commit 9e1a0cf

Please sign in to comment.