Upgrade helm #50
Merged
Upgrade helm #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosstrand
approved these changes
Dec 25, 2020
There was a problem hiding this comment.
Yeah! This change is important since we are facing this issue: #49
JeroenBoesten
approved these changes
Jan 4, 2021
|
Hi @carlosstrand and @JeroenBoesten thanks for approving this! Can you please verify if it is working for you so that i can finalize the changes? |
|
I can confirm that it solves the issue from #49 |
|
Hey team, can we merge this PR? (I need that fix to deploy a new version of my code to production) Thanks 🙏🏻 😢 |
|
@diogopms I am currently using a forked version of this repo with the above changes, given that it is taking time to merge this pr, I would recommend you to do the same |
|
This action is unusable unless this PR is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.