[stable/aws-s3-proxy]: Support k8s 1.19 Ingress #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-rocket-internet
approved these changes
Jun 13, 2023
There was a problem hiding this comment.
I would say don't even bother with the conditional logic, a new version of the chart will be created so there's no need for backwards compatibilty but all good! Thanks @BlueHorn07 💙
|
Oh, I didn't bumped chart version! I will bump it to |
auto-merge was automatically disabled
June 13, 2023 10:58
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ingress of
aws-s3-proxyonly supportnetworking.k8s.io/v1beta1andextensions/v1beta1, so it cannot be deployed over k8s 1.22 versions. (networking.k8s.io/v1is supported starting with k8s 1.19.)https://kubernetes.io/docs/reference/using-api/deprecation-guide/#ingress-v122
So, add if-else statements to support
networking.k8s.io/v1apiVersion. This change is compatible to k8s 1.19 under version, so don't worry :)Checklist
[stable/mychartname])