Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

These scripts need to be cleaned to meet contrib guide standards and moved from devel to master #184

Open
1 of 8 tasks
grantcurell opened this issue Feb 5, 2021 · 0 comments
Open
1 of 8 tasks

These scripts need to be cleaned to meet contrib guide standards and moved from devel to master #184

grantcurell opened this issue Feb 5, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@grantcurell
Copy link
Collaborator

grantcurell commented Feb 5, 2021 •
edited
Loading

The following scripts need to be cleaned and imported from devel:

  • get_chassis_profile.py
  • get_identitypool_usage.py
  • get_template.py
  • new_identity_pool.py
  • new_template.py
  • set_chassis_profile.py
  • set_template_identity_pool.py
  • set_template_vlan.py
@grantcurell grantcurell added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Feb 5, 2021
@grantcurell grantcurell mentioned this issue Feb 5, 2021
Closed
grantcurell added a commit to grantcurell/OpenManage-Enterprise that referenced this issue Feb 15, 2021
@grantcurell
new_template.py
96a06a4 
- added comments to all functions
- Updated file handling to use OS module
- Updated file handling to use with instead of a naked call
- Removed baseuri
- Made the template name optional
- Added additional user output
- Updated docs
- Addresses dell#184 for new_template.py

library code:
- added post functionality

readme.md
- Updated the readme with tips for writing your own code and added a note about feedback

Signed-off-by: Grant Curell <grant_curell@dell.com>
grantcurell added a commit to grantcurell/OpenManage-Enterprise that referenced this issue Feb 15, 2021
@grantcurell
new_template.py
63ab832 
- added comments to all functions
- Updated file handling to use OS module
- Updated file handling to use with instead of a naked call
- Removed baseuri
- Made the template name optional
- Added additional user output
- Updated docs
- Addresses dell#184 for new_template.py

library code:
- added post functionality

readme.md
- Updated the readme with tips for writing your own code and added a note about feedback

Signed-off-by: Grant Curell <grant_curell@dell.com>
@grantcurell grantcurell mentioned this issue Feb 15, 2021
Merged
grantcurell added a commit that referenced this issue Feb 15, 2021
@grantcurell
new_template.py
ff74742 
- added comments to all functions
- Updated file handling to use OS module
- Updated file handling to use with instead of a naked call
- Removed baseuri
- Made the template name optional
- Added additional user output
- Updated docs
- Addresses #184 for new_template.py

library code:
- added post functionality

readme.md
- Updated the readme with tips for writing your own code and added a note about feedback

Signed-off-by: Grant Curell <grant_curell@dell.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@grantcurell