Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support NVMe host management #68

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

P-Cao
Copy link
Collaborator

@P-Cao P-Cao commented Oct 25, 2024

Description

Add support for management of NVMe host

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, pep8, linting, or security issues
  • I have performed Ansible Sanity test using --docker default
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit Test
    Name Stmts Miss Branch BrPart Cover

plugins/modules/info.py 346 3 116 16 96%
plugins/modules/nvme_host.py 146 3 42 5 96%

@ansible-collections-svc
Copy link
Collaborator

Can one of the admins verify this patch?

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 93.23077% with 22 lines in your changes missing coverage. Please review.

Project coverage is 91.93%. Comparing base (27ecbd2) to head (34fd097).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
plugins/modules/nvme_host.py 87.67% 10 Missing and 8 partials ⚠️
plugins/modules/info.py 81.25% 2 Missing and 1 partial ⚠️
plugins/module_utils/storage/dell/utils.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
- Coverage   91.95%   91.93%   -0.03%     
==========================================
  Files          49       52       +3     
  Lines        7311     7673     +362     
  Branches      919      933      +14     
==========================================
+ Hits         6723     7054     +331     
- Misses        309      329      +20     
- Partials      279      290      +11     
Flag Coverage Δ
units 91.93% <93.23%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants