Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added writable snapshot in info module #101

Conversation

Kritika-Bhateja-03
Copy link
Contributor

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, pep8, linting, or security issues
  • I have performed Ansible Sanity test using --docker default
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 88.70968% with 7 lines in your changes missing coverage. Please review.

Project coverage is 82.24%. Comparing base (8a6e181) to head (d148b0d).
Report is 5 commits behind head on main.

Files Patch % Lines
...s/storage/dell/shared_library/writable_snapshot.py 84.61% 3 Missing and 1 partial ⚠️
plugins/modules/info.py 70.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
+ Coverage   82.21%   82.24%   +0.03%     
==========================================
  Files         123      124       +1     
  Lines       13307    13369      +62     
  Branches     1965     1975      +10     
==========================================
+ Hits        10940    10995      +55     
- Misses       1767     1772       +5     
- Partials      600      602       +2     
Flag Coverage Δ
units 82.24% <88.70%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/modules/info.rst Outdated Show resolved Hide resolved
playbooks/modules/info.yml Outdated Show resolved Hide resolved
plugins/modules/info.py Outdated Show resolved Hide resolved
playbooks/modules/info.yml Show resolved Hide resolved
@sachin-apa sachin-apa self-requested a review August 8, 2024 05:43
sachin-apa
sachin-apa previously approved these changes Aug 8, 2024
Copy link
Collaborator

@sachin-apa sachin-apa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation Completed !

sachin-apa
sachin-apa previously approved these changes Aug 14, 2024
felixs88
felixs88 previously approved these changes Aug 14, 2024
felixs88
felixs88 previously approved these changes Aug 14, 2024
sachin-apa
sachin-apa previously approved these changes Aug 14, 2024
trisha-dell
trisha-dell previously approved these changes Aug 14, 2024
Copy link
Contributor

@Bhavneet-Sharma Bhavneet-Sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a comment. Please have a look

@Bhavneet-Sharma Bhavneet-Sharma merged commit cfd066b into dell:main Aug 16, 2024
25 checks passed
@Kritika-Bhateja-03 Kritika-Bhateja-03 deleted the usr/Kriitka-Bhateja-03/ANSISILON-1990_update_info_module branch August 16, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants