Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[snapshot-util] remove date-util and urllib3 dependency. #102

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

sachin-apa
Copy link
Collaborator

@sachin-apa sachin-apa commented Aug 2, 2024

Description

Remove date-util and urllib3 dependency from the collection.
date-util has been replaced with python datetime library.
urllib3 is a transitive dependency for the collection, it is a required library for the sdk to make a API calls

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, pep8, linting, or security issues
  • I have performed Ansible Sanity test using --docker default
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Sanity
  • Playbook Run

@sachin-apa
Copy link
Collaborator Author

run e2e

trisha-dell
trisha-dell previously approved these changes Aug 2, 2024
@meenakshidembi691
Copy link
Contributor

Please check for the sanity failure

Bhavneet-Sharma
Bhavneet-Sharma previously approved these changes Aug 7, 2024
Copy link
Contributor

@Bhavneet-Sharma Bhavneet-Sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the sanity issues.

@sachin-apa
Copy link
Collaborator Author

Please check for the sanity failure

The sanity failures were because of devl pushes in ansible .. Addressed them

@sachin-apa sachin-apa force-pushed the feature-ANSISILON-1924-dateutil branch from 8b31e6a to 72d3c5d Compare August 7, 2024 13:19
@sachin-apa sachin-apa merged commit 19d8681 into dell:main Aug 7, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants