-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[snapshot-util] remove date-util and urllib3 dependency. #102
Merged
sachin-apa
merged 1 commit into
dell:main
from
sachin-apa:feature-ANSISILON-1924-dateutil
Aug 7, 2024
Merged
[snapshot-util] remove date-util and urllib3 dependency. #102
sachin-apa
merged 1 commit into
dell:main
from
sachin-apa:feature-ANSISILON-1924-dateutil
Aug 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sachin-apa
requested review from
Bhavneet-Sharma,
meenakshidembi691 and
trisha-dell
as code owners
August 2, 2024 09:45
run e2e |
trisha-dell
previously approved these changes
Aug 2, 2024
Kritika-Bhateja-03
previously approved these changes
Aug 5, 2024
meenakshidembi691
previously approved these changes
Aug 5, 2024
sachin-apa
dismissed stale reviews from meenakshidembi691, Kritika-Bhateja-03, and trisha-dell
via
August 7, 2024 05:11
2953171
sachin-apa
requested review from
meenakshidembi691,
trisha-dell and
Kritika-Bhateja-03
August 7, 2024 05:11
meenakshidembi691
previously approved these changes
Aug 7, 2024
Please check for the sanity failure |
Bhavneet-Sharma
previously approved these changes
Aug 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the sanity issues.
sachin-apa
dismissed stale reviews from Bhavneet-Sharma and meenakshidembi691
via
August 7, 2024 08:42
8b31e6a
Bhavneet-Sharma
approved these changes
Aug 7, 2024
The sanity failures were because of devl pushes in ansible .. Addressed them |
trisha-dell
approved these changes
Aug 7, 2024
sachin-apa
force-pushed
the
feature-ANSISILON-1924-dateutil
branch
from
August 7, 2024 13:19
8b31e6a
to
72d3c5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove date-util and urllib3 dependency from the collection.
date-util has been replaced with python datetime library.
urllib3 is a transitive dependency for the collection, it is a required library for the sdk to make a API calls
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration