Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding fix for ANSISILON-2017 #111

Conversation

trisha-dell
Copy link
Collaborator

Description

Fix for allowing spaces in SMB share name

GitHub Issues

GitHub Issue #
#104

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, pep8, linting, or security issues
  • I have performed Ansible Sanity test using --docker default
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Functional testing
  • Unit testing

sachin-apa
sachin-apa previously approved these changes Sep 2, 2024
Bhavneet-Sharma
Bhavneet-Sharma previously approved these changes Sep 2, 2024
@sachin-apa sachin-apa linked an issue Sep 17, 2024 that may be closed by this pull request
@Bhavneet-Sharma Bhavneet-Sharma merged commit 034121c into dell:main Sep 18, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: SMB Module Fails with Space in share_name
5 participants