Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing masked paths in response for NFS module #112

Merged
merged 11 commits into from
Sep 19, 2024

Conversation

trisha-dell
Copy link
Collaborator

Description

Removing masked paths and adding a declarative approach for clients for NFS.

GitHub Issues

GitHub Issue #
#98
#74

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, pep8, linting, or security issues
  • I have performed Ansible Sanity test using --docker default
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Functional Test
  • Unit Test

Bhavneet-Sharma
Bhavneet-Sharma previously approved these changes Sep 3, 2024
plugins/modules/nfs.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@sachin-apa sachin-apa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets also add playbook exmaples.

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 91.04478% with 18 lines in your changes missing coverage. Please review.

Project coverage is 82.45%. Comparing base (c5b1405) to head (79ae426).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
plugins/modules/nfs.py 82.47% 5 Missing and 12 partials ⚠️
...s/unit/plugins/module_utils/mock_nfs_export_api.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
+ Coverage   81.90%   82.45%   +0.54%     
==========================================
  Files         124      133       +9     
  Lines       13463    14304     +841     
  Branches     1989     2107     +118     
==========================================
+ Hits        11027    11794     +767     
- Misses       1830     1864      +34     
- Partials      606      646      +40     
Flag Coverage Δ
units 82.45% <91.04%> (+0.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sachin-apa sachin-apa merged commit 705e9de into dell:main Sep 19, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants