Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: ADS Enhancements #114

Merged
merged 16 commits into from
Sep 19, 2024

Conversation

Bhavneet-Sharma
Copy link
Contributor

@Bhavneet-Sharma Bhavneet-Sharma commented Sep 4, 2024

Description

PR contains the enhancements for ADS module

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
#95

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, pep8, linting, or security issues
  • I have performed Ansible Sanity test using --docker default
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 88.67925% with 36 lines in your changes missing coverage. Please review.

Project coverage is 82.93%. Comparing base (c5b1405) to head (21a57c2).
Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
plugins/modules/ads.py 84.61% 10 Missing and 12 partials ⚠️
plugins/module_utils/storage/dell/utils.py 17.64% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
+ Coverage   81.90%   82.93%   +1.02%     
==========================================
  Files         124      133       +9     
  Lines       13463    14454     +991     
  Branches     1989     2126     +137     
==========================================
+ Hits        11027    11987     +960     
+ Misses       1830     1820      -10     
- Partials      606      647      +41     
Flag Coverage Δ
units 82.93% <88.67%> (+1.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@trisha-dell trisha-dell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the sample playbooks.

@Bhavneet-Sharma
Copy link
Contributor Author

Please update the sample playbooks.

Done. Please review.

sachin-apa
sachin-apa previously approved these changes Sep 19, 2024
@Bhavneet-Sharma Bhavneet-Sharma merged commit 5a7f60d into dell:main Sep 19, 2024
22 checks passed
@Bhavneet-Sharma Bhavneet-Sharma deleted the feature-ads-enhacements branch November 19, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Add missing ADS options for ads module
5 participants