Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Role Module Changes #84

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Conversation

meenakshidembi691
Copy link
Contributor

@meenakshidembi691 meenakshidembi691 commented Jun 21, 2024

Description

Added Role Module for PowerScale

Checklist:

  • [ x ] I have performed a self-review of my own code to ensure there are no formatting, pep8, linting, or security issues
  • [ x ] I have performed Ansible Sanity test using --docker default
  • [ x ] I have verified that new and existing unit tests pass locally with my changes
  • [ x ] I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2024

Codecov Report

Attention: Patch coverage is 88.70968% with 63 lines in your changes missing coverage. Please review.

Project coverage is 82.37%. Comparing base (16d597e) to head (6655da7).
Report is 2 commits behind head on main.

Files Patch % Lines
plugins/modules/role.py 84.00% 31 Missing and 21 partials ⚠️
tests/unit/plugins/modules/test_role.py 96.34% 6 Missing ⚠️
tests/unit/plugins/module_utils/mock_role_api.py 88.88% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
+ Coverage   80.66%   82.37%   +1.70%     
==========================================
  Files         107      116       +9     
  Lines       11432    12600    +1168     
  Branches     1678     1848     +170     
==========================================
+ Hits         9222    10379    +1157     
+ Misses       1675     1654      -21     
- Partials      535      567      +32     
Flag Coverage Δ
units 82.37% <88.70%> (+1.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Bhavneet-Sharma Bhavneet-Sharma merged commit 5f6b156 into dell:main Jun 24, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants