Filtering get topology count for specific sc key bug fix #126
+87
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aqu-dell
requested review from
adarsh-dell,
AkshaySainiDell,
bharathsreekanth,
harishp8889,
JacobGros,
Prabhu-Dell,
rajkumar-palani,
khareRajshree,
shefali-malhotra,
panigs7,
tssushma,
gilltaran,
shanmydell,
alikdell,
atye,
coulof,
shaynafinocchiaro,
xuluna and
EvgenyUglov
as code owners
sharmilarama
previously approved these changes
Jan 13, 2025
shaynafinocchiaro
previously approved these changes
Jan 13, 2025
AronAtDell
reviewed
Jan 13, 2025
| @@ -0,0 +1,51 @@ | |||
| /* | |||
| * | |||
| * Copyright © 2024 Dell Inc. or its subsidiaries. All Rights Reserved. | |||
There was a problem hiding this comment.
Change the copyright to 2025. Thanks!
aqu-dell
dismissed stale reviews from shaynafinocchiaro, sharmilarama, kumarkgosa, and jooseppi-luna
via
9d7e8bd
shaynafinocchiaro
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Customer was facing issue with running cert-csi functional test when they had multiple drivers installed. The issue with the test was that it was getting all the topologies for all drivers when it should only get the topologies for the specific driver being tested.
To resolve this, we will only get topology keys based on the ones listed in the storage class for the test.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Reproduced the user's issue by running the functional-test without the changes. Saw that topologies for all the drivers were being retrieved and test timed out.
Reran the test with the changes and saw that only the topologies for the specific driver that was listed in the storage class was being retrieved. Test passed successfully
