Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update amaas reference #15

Merged
merged 1 commit into from
Feb 24, 2023
Merged

Update amaas reference #15

merged 1 commit into from
Feb 24, 2023

Conversation

satyakonduri
Copy link
Contributor

@satyakonduri satyakonduri commented Feb 24, 2023 •
edited
Loading

Description

Remove internal artifactory reference.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#628

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • make build
  • PowerStore
  • unity
  • PowerMax

@satyakonduri satyakonduri marked this pull request as ready for review February 24, 2023 11:20
@satyakonduri satyakonduri self-assigned this Feb 24, 2023
tssushma
tssushma approved these changes Feb 24, 2023
View reviewed changes
Copy link

@tssushma tssushma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
Tested it against the CSI-Powermax driver.
Working fine and it is taking the proper image( docker.io/centos:latest)

@satyakonduri satyakonduri merged commit 2a7881a into main Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suryagupta4 suryagupta4 suryagupta4 approved these changes

@tssushma tssushma tssushma approved these changes

@adarsh-dell adarsh-dell Awaiting requested review from adarsh-dell adarsh-dell is a code owner

@AkshaySainiDell AkshaySainiDell Awaiting requested review from AkshaySainiDell AkshaySainiDell is a code owner

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth bharathsreekanth is a code owner

@harishp8889 harishp8889 Awaiting requested review from harishp8889 harishp8889 is a code owner

@JacobGros JacobGros Awaiting requested review from JacobGros JacobGros is a code owner

@Prabhu-Dell Prabhu-Dell Awaiting requested review from Prabhu-Dell Prabhu-Dell is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani rajkumar-palani is a code owner

@khareRajshree khareRajshree Awaiting requested review from khareRajshree khareRajshree is a code owner

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra shefali-malhotra is a code owner

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 is a code owner

@gilltaran gilltaran Awaiting requested review from gilltaran gilltaran is a code owner

@shanmydell shanmydell Awaiting requested review from shanmydell shanmydell is a code owner

@kenivi1 kenivi1 Awaiting requested review from kenivi1

Assignees

@satyakonduri satyakonduri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@satyakonduri @tssushma @suryagupta4