Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update client libraries #90

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Update client libraries #90

merged 1 commit into from
Oct 29, 2024

Conversation

shaynafinocchiaro
Copy link
Contributor

Description

Update client libraries

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1435

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • make all
  • unit tests
PASS
--- PASS: TestExecuteE2ECommand (0.57s)
    --- PASS: TestExecuteE2ECommand/execute_with_proper_arguments (0.57s)
=== RUN   TestGenerateReport
=== RUN   TestGenerateReport/send_correct_report_
TestSuite Name: Kubernetes e2e suite
Total Tests Executed: 47
Total Tests Passed: 47
Total Tests Failed: 0
--- PASS: TestGenerateReport (0.00s)
    --- PASS: TestGenerateReport/send_correct_report_ (0.00s)
=== RUN   TestParse
--- PASS: TestParse (0.00s)
PASS
coverage: 71.9% of statements
ok      github.com/dell/cert-csi/pkg/utils      35.488s coverage: 71.9% of statements

@anandrajak1 anandrajak1 merged commit 443fb44 into main Oct 29, 2024
4 checks passed
@anandrajak1 anandrajak1 deleted the gomod branch October 29, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants