Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use common base image #187

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Use common base image #187

merged 2 commits into from
Nov 9, 2023

Conversation

tdawe
Copy link
Contributor

@tdawe tdawe commented Nov 8, 2023

Description

Use common base image from configuration file located in our dell/csm repository: https://github.com/dell/csm/blob/main/config/csm-common.mk

All CSM drivers and modules will download this file as part of the build process and use the defined base image. When a base image is updated, the file in dell/csm will be updated and the next build of CSM drivers and modules will automatically use this new image.

Since we are using a single environment variable for the base image and don't have a separate DIGEST value, I also disabled the hadolint check for explicitly tagging an image.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1031

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit testing
  • Integration testing

Special Notes For Your Reviewer:

Please describe the parts of code reviewers should focus on.

Additional documentation

  • Enhancement proposals
  • Usage documentation

@csmbot
Copy link
Collaborator

csmbot commented Nov 8, 2023

Can one of the admins verify this patch?

@tdawe tdawe merged commit 0e06318 into main Nov 9, 2023
7 checks passed
@tdawe tdawe deleted the use-common-base-image branch November 9, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants