Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-197] crd job annotation #198

Merged
merged 2 commits into from
Dec 21, 2023
Merged

[ISSUE-197] crd job annotation #198

merged 2 commits into from
Dec 21, 2023

Conversation

rafalw82
Copy link
Collaborator

Purpose

Issue #197

Providing job's pod annotation placeholder in order to be able to provide additional annotations from values during helm install/upgrade.

PR checklist

  • Add link to the issue
  • Choose Project
  • Choose PR label
  • New unit tests added
  • Modified code has meaningful comments
  • All TODOs are linked with the issues
  • All comments are resolved

Testing

Deployment.

@rafalw82 rafalw82 added the enhancement New feature or request label Dec 20, 2023
Signed-off-by: rafalw82 <rafal.wegrzyn@dell.com>
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (550cc4e) 59.68% compared to head (934af68) 59.68%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #198   +/-   ##
=======================================
  Coverage   59.68%   59.68%           
=======================================
  Files          10       10           
  Lines        1156     1156           
=======================================
  Hits          690      690           
  Misses        399      399           
  Partials       67       67           
Flag Coverage Δ
unittests 59.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rafalw82 rafalw82 merged commit 254bac3 into master Dec 21, 2023
4 checks passed
@rafalw82 rafalw82 deleted the feature-197-annotation branch December 21, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants