Skip to content

Commit

Permalink
Revert "use /ci to trigger e2e"
Browse files Browse the repository at this point in the history
This reverts commit 431e34f.

Signed-off-by: Shi, Crane <crane.shi@emc.com>
  • Loading branch information
CraneShiEMC committed May 13, 2023
1 parent 431e34f commit c74f5ac
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ name: e2e
on:
push:
branches: [ master ]
issue_comment:
types: [ created ]
pull_request_review:
types: [submitted]

env:
REGISTRY: 'ghcr.io/dell/csi-baremetal'
Expand All @@ -17,7 +17,7 @@ env:
jobs:
e2e:
# we need to start validation on master push or on /ci comment in PR only
if: github.event_name == 'push' || (github.event.issue.pull_request && github.event_name == 'issue_comment' && startsWith(github.event.comment.body, '/ci'))
if: github.event_name == 'push' || github.event.review.state == 'approved'
runs-on: ubuntu-20.04
steps:
- name: Get operator branch
Expand Down Expand Up @@ -45,7 +45,7 @@ jobs:
# Since the issue comment event runs against the main branch
# we need to figure out a way to checkout the correct revision
# if we want to work with the changes from a pull request.
if: github.event.issue.pull_request && startsWith(github.event.comment.body, '/ci')
if: github.event.issue.pull_request_review
id: sha
uses: actions/github-script@v4
with:
Expand All @@ -61,7 +61,7 @@ jobs:
# Set ref if triggered from comment
- name: Check out code
if: github.event.issue.pull_request && startsWith(github.event.comment.body, '/ci')
if: github.event.issue.pull_request_review
uses: actions/checkout@v2
with:
ref: '${{ steps.sha.outputs.result }}'
Expand Down

0 comments on commit c74f5ac

Please sign in to comment.