Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE-707] volume release label added #708

Merged
merged 1 commit into from
Jan 24, 2022
Merged

[ISSUE-707] volume release label added #708

merged 1 commit into from
Jan 24, 2022

Conversation

mishoyama
Copy link
Collaborator

@mishoyama mishoyama commented Jan 24, 2022 •
edited
Loading

Purpose

Resolves #707

Add release label in addition to app

PR checklist

  • Add link to the issue
  • Choose Project
  • Choose PR label
  • New unit tests added
  • Modified code has meaningful comments
  • All TODOs are linked with the issues
  • All comments are resolved

Testing

borism1@borism1-VirtualBox:/workspace/csi-baremetal> kubectl get volumes -l release=my-release
NAME                                       SIZE        STORAGE CLASS   HEALTH   CSI_STATUS   LOCATION                               NODE
pvc-0b7fe462-ae56-4f3a-825a-1eec063f42e1   105906176   HDD             GOOD     PUBLISHED    c0e80b86-e518-4add-af48-b621142f7adc   56f323f7-8ec7-49fc-9481-82c20f3f1938
pvc-267e5ca3-3cdd-4ffd-8d4a-3196d42a28c7   105906176   HDD             GOOD     PUBLISHED    a66ba14f-c339-4af8-82c1-c5366db5efea   1571b49f-089e-456e-8a50-cea24af722f5
pvc-2726b055-2ee9-4eaf-a11c-9a8981f876f0   105906176   HDD             GOOD     PUBLISHED    dd62ff42-6a2e-4a94-8570-cf9b9e56b2cc   fe019a59-8300-4129-bc48-3a233a3e24d2
pvc-294c57f1-e88d-4144-a0b9-183e653d50ce   105906176   HDD             GOOD     PUBLISHED    cf56fc6a-c1a7-4975-ba88-2c09f857e116   1571b49f-089e-456e-8a50-cea24af722f5
pvc-3c657411-414c-4a2b-b459-8cee2f81eab0   105906176   HDD             GOOD     PUBLISHED    67e7d32b-b42d-40aa-baa1-52ac288a7335   56f323f7-8ec7-49fc-9481-82c20f3f1938
pvc-3d3df2a6-cec5-4384-bba0-fe6e64825315   105906176   HDD             GOOD     PUBLISHED    967d8c09-26a9-4fe8-9256-559c0690b002   e465df3b-6e3a-4075-9a09-6071ca146991
pvc-3e897115-eb47-430e-9835-35b7dc98d149   105906176   HDD             GOOD     PUBLISHED    a7f09cd6-0a06-442a-86a2-9afc0744f501   fe019a59-8300-4129-bc48-3a233a3e24d2
pvc-4c2a650c-d3c5-43b0-86ef-b5d98358339c   105906176   HDD             GOOD     PUBLISHED    c869e841-5322-4852-ac2a-8dfe464132bd   56f323f7-8ec7-49fc-9481-82c20f3f1938
pvc-56098a78-3433-40f8-affa-87ed9ba975e8   105906176   HDD             GOOD     PUBLISHED    796a8ef4-50bc-4efa-8e9e-527be2d065d3   1571b49f-089e-456e-8a50-cea24af722f5
pvc-d1c29885-0776-4e5e-92ac-2b158abcabe6   105906176   HDD             GOOD     PUBLISHED    a36c8212-22b8-42f9-98c6-7e4df7bc1972   fe019a59-8300-4129-bc48-3a233a3e24d2
pvc-ecc358ed-35e5-4c91-80f1-5326897754cd   105906176   HDD             GOOD     PUBLISHED    c7ab16fe-1bd9-4f27-aa5f-0c6b177efe76   e465df3b-6e3a-4075-9a09-6071ca146991
pvc-eee27c90-0242-472d-b1ea-c11d41762bb7   105906176   HDD             GOOD     PUBLISHED    8d9ea3df-fd00-444f-aa13-9062dd89c8ad   e465df3b-6e3a-4075-9a09-6071ca146991
borism1@borism1-VirtualBox:/workspace/csi-baremetal> kubectl get volumes -l app=nginx
NAME                                       SIZE        STORAGE CLASS   HEALTH   CSI_STATUS   LOCATION                               NODE
pvc-0b7fe462-ae56-4f3a-825a-1eec063f42e1   105906176   HDD             GOOD     PUBLISHED    c0e80b86-e518-4add-af48-b621142f7adc   56f323f7-8ec7-49fc-9481-82c20f3f1938
pvc-267e5ca3-3cdd-4ffd-8d4a-3196d42a28c7   105906176   HDD             GOOD     PUBLISHED    a66ba14f-c339-4af8-82c1-c5366db5efea   1571b49f-089e-456e-8a50-cea24af722f5
pvc-2726b055-2ee9-4eaf-a11c-9a8981f876f0   105906176   HDD             GOOD     PUBLISHED    dd62ff42-6a2e-4a94-8570-cf9b9e56b2cc   fe019a59-8300-4129-bc48-3a233a3e24d2
pvc-294c57f1-e88d-4144-a0b9-183e653d50ce   105906176   HDD             GOOD     PUBLISHED    cf56fc6a-c1a7-4975-ba88-2c09f857e116   1571b49f-089e-456e-8a50-cea24af722f5
pvc-3c657411-414c-4a2b-b459-8cee2f81eab0   105906176   HDD             GOOD     PUBLISHED    67e7d32b-b42d-40aa-baa1-52ac288a7335   56f323f7-8ec7-49fc-9481-82c20f3f1938
pvc-3d3df2a6-cec5-4384-bba0-fe6e64825315   105906176   HDD             GOOD     PUBLISHED    967d8c09-26a9-4fe8-9256-559c0690b002   e465df3b-6e3a-4075-9a09-6071ca146991
pvc-3e897115-eb47-430e-9835-35b7dc98d149   105906176   HDD             GOOD     PUBLISHED    a7f09cd6-0a06-442a-86a2-9afc0744f501   fe019a59-8300-4129-bc48-3a233a3e24d2
pvc-4c2a650c-d3c5-43b0-86ef-b5d98358339c   105906176   HDD             GOOD     PUBLISHED    c869e841-5322-4852-ac2a-8dfe464132bd   56f323f7-8ec7-49fc-9481-82c20f3f1938
pvc-56098a78-3433-40f8-affa-87ed9ba975e8   105906176   HDD             GOOD     PUBLISHED    796a8ef4-50bc-4efa-8e9e-527be2d065d3   1571b49f-089e-456e-8a50-cea24af722f5
pvc-d1c29885-0776-4e5e-92ac-2b158abcabe6   105906176   HDD             GOOD     PUBLISHED    a36c8212-22b8-42f9-98c6-7e4df7bc1972   fe019a59-8300-4129-bc48-3a233a3e24d2
pvc-ecc358ed-35e5-4c91-80f1-5326897754cd   105906176   HDD             GOOD     PUBLISHED    c7ab16fe-1bd9-4f27-aa5f-0c6b177efe76   e465df3b-6e3a-4075-9a09-6071ca146991
pvc-eee27c90-0242-472d-b1ea-c11d41762bb7   105906176   HDD             GOOD     PUBLISHED    8d9ea3df-fd00-444f-aa13-9062dd89c8ad   e465df3b-6e3a-4075-9a09-6071ca146991
borism1@borism1-VirtualBox:/workspace/csi-baremetal> kubectl get volumes -l app.kubernetes.io/name=nginx
NAME                                       SIZE        STORAGE CLASS   HEALTH   CSI_STATUS   LOCATION                               NODE
pvc-0b7fe462-ae56-4f3a-825a-1eec063f42e1   105906176   HDD             GOOD     PUBLISHED    c0e80b86-e518-4add-af48-b621142f7adc   56f323f7-8ec7-49fc-9481-82c20f3f1938
pvc-267e5ca3-3cdd-4ffd-8d4a-3196d42a28c7   105906176   HDD             GOOD     PUBLISHED    a66ba14f-c339-4af8-82c1-c5366db5efea   1571b49f-089e-456e-8a50-cea24af722f5
pvc-2726b055-2ee9-4eaf-a11c-9a8981f876f0   105906176   HDD             GOOD     PUBLISHED    dd62ff42-6a2e-4a94-8570-cf9b9e56b2cc   fe019a59-8300-4129-bc48-3a233a3e24d2
pvc-294c57f1-e88d-4144-a0b9-183e653d50ce   105906176   HDD             GOOD     PUBLISHED    cf56fc6a-c1a7-4975-ba88-2c09f857e116   1571b49f-089e-456e-8a50-cea24af722f5
pvc-3c657411-414c-4a2b-b459-8cee2f81eab0   105906176   HDD             GOOD     PUBLISHED    67e7d32b-b42d-40aa-baa1-52ac288a7335   56f323f7-8ec7-49fc-9481-82c20f3f1938
pvc-3d3df2a6-cec5-4384-bba0-fe6e64825315   105906176   HDD             GOOD     PUBLISHED    967d8c09-26a9-4fe8-9256-559c0690b002   e465df3b-6e3a-4075-9a09-6071ca146991
pvc-3e897115-eb47-430e-9835-35b7dc98d149   105906176   HDD             GOOD     PUBLISHED    a7f09cd6-0a06-442a-86a2-9afc0744f501   fe019a59-8300-4129-bc48-3a233a3e24d2
pvc-4c2a650c-d3c5-43b0-86ef-b5d98358339c   105906176   HDD             GOOD     PUBLISHED    c869e841-5322-4852-ac2a-8dfe464132bd   56f323f7-8ec7-49fc-9481-82c20f3f1938
pvc-56098a78-3433-40f8-affa-87ed9ba975e8   105906176   HDD             GOOD     PUBLISHED    796a8ef4-50bc-4efa-8e9e-527be2d065d3   1571b49f-089e-456e-8a50-cea24af722f5
pvc-d1c29885-0776-4e5e-92ac-2b158abcabe6   105906176   HDD             GOOD     PUBLISHED    a36c8212-22b8-42f9-98c6-7e4df7bc1972   fe019a59-8300-4129-bc48-3a233a3e24d2
pvc-ecc358ed-35e5-4c91-80f1-5326897754cd   105906176   HDD             GOOD     PUBLISHED    c7ab16fe-1bd9-4f27-aa5f-0c6b177efe76   e465df3b-6e3a-4075-9a09-6071ca146991
pvc-eee27c90-0242-472d-b1ea-c11d41762bb7   105906176   HDD             GOOD     PUBLISHED    8d9ea3df-fd00-444f-aa13-9062dd89c8ad   e465df3b-6e3a-4075-9a09-6071ca146991

add release label to volume custom resource
a33557b 
Signed-off-by: Mikhail Borisov <mikhail.borisov@dell.com>
@mishoyama mishoyama added the enhancement New feature or request label Jan 24, 2022
@mishoyama mishoyama requested a review from a team January 24, 2022 09:01
@mishoyama mishoyama self-assigned this Jan 24, 2022
@rkiselenko
Copy link
Contributor

/ci

@mishoyama mishoyama merged commit bfafb34 into release-1.0 Jan 24, 2022
@mishoyama mishoyama deleted the feature-issue-707-volume-release-label branch January 24, 2022 11:43
mishoyama added a commit that referenced this pull request Feb 2, 2022
@mishoyama
[ISSUE-707] volume release label added (#708)
8d9a544 
Signed-off-by: Mikhail Borisov <mikhail.borisov@dell.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkiselenko rkiselenko rkiselenko approved these changes

@safronovD safronovD safronovD approved these changes

@yurkov-anton yurkov-anton yurkov-anton approved these changes

Assignees

@mishoyama mishoyama

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mishoyama @rkiselenko @yurkov-anton @safronovD