Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(linters): added golangci-lint #25

Merged
merged 1 commit into from
Aug 11, 2023
Merged

ci(linters): added golangci-lint #25

merged 1 commit into from
Aug 11, 2023

Conversation

shanduur-dell
Copy link
Contributor

@shanduur-dell shanduur-dell commented Aug 2, 2023 •
edited
Loading

Description

This PR adds golangci-lint linters aggregator.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#926

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

N/A

Special Notes For Your Reviewer:

This was discussed and accepted during meeting on 2023-08-01.

Additional documentation

N/A

@shanduur-dell
ci(linters): added golangci-lint
686c07a 
Signed-off-by: shanduur-dell <mateusz.urbanek@dell.com>
@JacobGros JacobGros merged commit a6ad143 into main Aug 11, 2023
3 of 4 checks passed
@JacobGros JacobGros deleted the ci-add-golangci-lint branch August 11, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshitap26 harshitap26 harshitap26 approved these changes

@JacobGros JacobGros JacobGros approved these changes

@donatwork donatwork donatwork approved these changes

@adarsh-dell adarsh-dell Awaiting requested review from adarsh-dell adarsh-dell is a code owner

@AkshaySainiDell AkshaySainiDell Awaiting requested review from AkshaySainiDell AkshaySainiDell is a code owner

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004 bpjain2004 is a code owner

@francis-nijay francis-nijay Awaiting requested review from francis-nijay francis-nijay is a code owner

@harishp8889 harishp8889 Awaiting requested review from harishp8889 harishp8889 is a code owner

@niranjan-n1 niranjan-n1 Awaiting requested review from niranjan-n1 niranjan-n1 is a code owner

@kumarp20 kumarp20 Awaiting requested review from kumarp20 kumarp20 is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@satyakonduri satyakonduri Awaiting requested review from satyakonduri satyakonduri is a code owner

@suryagupta4 suryagupta4 Awaiting requested review from suryagupta4 suryagupta4 is a code owner

@gilltaran gilltaran Awaiting requested review from gilltaran gilltaran is a code owner

@kenivi1 kenivi1 Awaiting requested review from kenivi1 kenivi1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shanduur-dell @donatwork @JacobGros @harshitap26