Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added k8s1.26 support #151

Merged
merged 3 commits into from
Jan 9, 2023
Merged

Added k8s1.26 support #151

merged 3 commits into from
Jan 9, 2023

Conversation

KshitijaKakde
Copy link
Contributor

Description

This PR enables driver to install on k8s 1.26

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#583

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@KshitijaKakde
Changed chart.yaml and helpers.tpl with 1.26
30cfa2f 
Signed-off-by: Kshitija Kakde <Kshitija_Kakde@Dell.com>
@KshitijaKakde
kuberversion changed to 1.27
3e00d1f 
Signed-off-by: Kshitija Kakde <Kshitija_Kakde@Dell.com>
@KshitijaKakde KshitijaKakde reopened this Jan 9, 2023
VamsiSiddu-7
VamsiSiddu-7 previously approved these changes Jan 9, 2023
View reviewed changes
ashleyvjoy
ashleyvjoy previously approved these changes Jan 9, 2023
View reviewed changes
khareRajshree
khareRajshree previously approved these changes Jan 9, 2023
View reviewed changes
JacobGros
JacobGros approved these changes Jan 9, 2023
View reviewed changes
Copy link
Collaborator

@JacobGros JacobGros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KshitijaKakde KshitijaKakde merged commit 3240747 into main Jan 9, 2023
@KshitijaKakde KshitijaKakde deleted the kshitija-k8s1.26-support branch January 9, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobGros JacobGros JacobGros approved these changes

@bharathsreekanth bharathsreekanth bharathsreekanth approved these changes

@khareRajshree khareRajshree khareRajshree left review comments

@VamsiSiddu-7 VamsiSiddu-7 VamsiSiddu-7 left review comments

@ashleyvjoy ashleyvjoy ashleyvjoy left review comments

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell

@jooseppi-luna jooseppi-luna Awaiting requested review from jooseppi-luna

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@KshitijaKakde @JacobGros @khareRajshree @bharathsreekanth @VamsiSiddu-7 @ashleyvjoy